Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lld version check more robust #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eleanor-arm
Copy link

Modified or downstream versions of lld might extend the --version
output to include further lines of information. This change tightens
up the sed command so that it will only extract a version number
appearing after the name "LLD"; quit after printing the first one it
finds; and not emit additional lines of --version text that don't
include a version number at all.

"Contribution covered by the CLA"

Modified or downstream versions of lld might extend the --version
output to include further lines of information. This change tightens
up the sed command so that it will only extract a version number
appearing after the name "LLD"; quit after printing the first one it
finds; and not emit additional lines of --version text that don't
include a version number at all.

"Contribution covered by the CLA"
@admlck
Copy link
Contributor

admlck commented Jun 11, 2024

Thank you. The change has been reviewed and merged internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants