fix(send_kcidb): Do not crash if optional field is missing

Some fields might be not present, as they are optional in model. Also add this field in custom checkout, even it is not mandatory, it is better to have it for consistency. Signed-off-by: Denys Fedoryshchenko <[email protected]>
kernelci · Nov 7, 2024 · 7310cbf · 7310cbf
1 parent 582e677
commit 7310cbf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/lava_callback.py b/src/lava_callback.py
@@ -606,7 +606,8 @@ async def checkout(data: ManualCheckout, request: Request,
                 "tree": treename,
                 "branch": branch,
                 "commit": commit,
-                "url": treeurl
+                "url": treeurl,
+                "tip_of_branch": False
             }
         },
         "timeout": checkout_timeout.isoformat(),

diff --git a/src/send_kcidb.py b/src/send_kcidb.py
@@ -141,11 +141,11 @@ def _parse_checkout_node(self, origin, checkout_node):
             'git_repository_branch':
                 checkout_node['data']['kernel_revision']['branch'],
             'git_commit_tags':
-                checkout_node['data']['kernel_revision']['commit_tags'],
+                checkout_node['data']['kernel_revision'].get('commit_tags'),
             'git_commit_message':
-                checkout_node['data']['kernel_revision']['commit_message'],
+                checkout_node['data']['kernel_revision'].get('commit_message'),
             'git_repository_branch_tip':
-                checkout_node['data']['kernel_revision']['tip_of_branch'],
+                checkout_node['data']['kernel_revision'].get('tip_of_branch'),
             'start_time': self._set_timezone(checkout_node['created']),
             'patchset_hash': '',
             'misc': {