-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api.models: Add patchset field to node revision #380
Conversation
Signed-off-by: Nikolay Yurin <[email protected]>
This and other PRs still need to be properly reviewed though, as per the discussions in previous Open Hours. I think it's making good progress and ideally this should be part of the stable candidates for the 4th Dec milestone. |
@yurinnick Also please consider adding unit tests and end-to-end tests to cover the new field and patchset functionality. This could be done as a follow-up, it would have been nice to have it as part of the same PR ideally but I don't think it's a blocking issue. |
Adding |
@yurinnick With #433 merged this PR will need to be converted into a change to Please let me know if it would be OK with you if I moved this change there (preserving your SoB of course), tag kernelci/kernelci-pipeline#342 with a new dependency and later close this PR. |
This patch was initially submitted as kernelci/kernelci-api#380 but required moving after merging kernelci/kernelci-api#433. Signed-off-by: Nikolay Yurin <[email protected]>
This patch was initially submitted as kernelci/kernelci-api#380 but required moving after merging kernelci/kernelci-api#433. Signed-off-by: Nikolay Yurin <[email protected]> Signed-off-by: Paweł Wieczorek <[email protected]>
This patch was initially submitted as kernelci/kernelci-api#380 but required moving after merging kernelci/kernelci-api#433. Signed-off-by: Nikolay Yurin <[email protected]> Signed-off-by: Paweł Wieczorek <[email protected]>
These changes have been moved to |
Implement
patchset
field for Node revision as discussed in #307: