bpf: Fix incorrect precision backtracking #4599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
Hi, The process_iter_arg check function misses the type check on the iter args, which leads to any pointer types can be passed as iter args. As the attached testcase shows, when I pass a ptr_to_map_value whose offset is 0, process_iter_arg still regards it as a stack pointer and use its offset to check the stack slot types. In this case, as long as the stack slot types matched with the ptr_to_map_value offset is correct, then checks can be bypassed. I attached the fix, which checks if the argument type is stack pointer. Please let me know if this fix might be incomplete. I'm happy to revise it. Best, Tao Signed-off-by: Tao Lyu <[email protected]>
|
Upstream branch: 77017b9 |
kernel-patches-daemon-bpf-rc
bot
added
new
bpf-next
V1
changes-requested
and removed
new
labels
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=905544 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Fix incorrect precision backtracking
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=905544