Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bpf, test_run: Fix LIVE_FRAME frame update after a page has been recy…
…cled The test_run code detects whether a page has been modified and re-initialises the xdp_frame structure if it has, using xdp_update_frame_from_buff(). However, xdp_update_frame_from_buff() doesn't touch frame->mem, so that wasn't correctly re-initialised, which led to the pages from page_pool not being returned correctly. Syzbot noticed this as a memory leak. Fix this by also copying the frame->mem structure when re-initialising the frame, like we do on initialisation of a new page from page_pool. Fixes: e5995bc ("bpf, test_run: fix crashes due to XDP frame overwriting/corruption") Fixes: b530e9e ("bpf: Add "live packet" mode for XDP in BPF_PROG_RUN") Reported-by: [email protected] Signed-off-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: [email protected] Reviewed-by: Alexander Lobakin <[email protected]> Acked-by: Stanislav Fomichev <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
- Loading branch information