Fix code scanning alert no. 39: Arbitrary file access during archive extraction ("Zip Slip") #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraction ("Zip Slip")
Fix the possibility that someone would download a sneaky grobid home which will be used to write arbitrary files outside the designated temporary directory
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/kermitt2/grobid/security/code-scanning/39
To fix the problem, we need to ensure that the file paths constructed from zip entries are validated to prevent writing files to unexpected locations. This can be achieved by normalizing the file paths and ensuring they start with the intended destination directory.
toPath().normalize().startsWith().Suggested fixes powered by Copilot Autofix. Review carefully before merging.