Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements and install instructions for multi-backend keras #1257

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

mattdangerw
Copy link
Member

@mattdangerw mattdangerw commented Sep 26, 2023

Tensorflow 2.14 is finally coming out, with cuda support via pip. Feels like a good time to update our instructions to make multi-backend GPU support a little easier (without help it is pretty hard).

A few notes:

  • We don't really need conda as we were using it for cuda (which we can now get via pip). So we could consider venv or pyenv etc.
  • We could almost have one single environment with cuda support, but it doesn't quite work. torch ships with cuda inside it's own pip, and jax will link to the torch specific cuda and blow up 🤮

@mattdangerw
Copy link
Member Author

I'll probably wait for tensorflow-text 2.14 to get to pypi to merge, but can review on this whenever.

@mattdangerw
Copy link
Member Author

/gcbrun

Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
requirements-jax-cuda.txt Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw mattdangerw merged commit a4db0d1 into keras-team:master Oct 9, 2023
8 of 9 checks passed
mattdangerw added a commit to mattdangerw/keras-hub that referenced this pull request Dec 7, 2023
…eras-team#1257)

* Update requirements and install instructions for multi-backend keras

* Address comments

* less strict bounds

* Update to released tf-text

* Match keras versions
mattdangerw added a commit to mattdangerw/keras-hub that referenced this pull request Dec 7, 2023
…eras-team#1257)

* Update requirements and install instructions for multi-backend keras

* Address comments

* less strict bounds

* Update to released tf-text

* Match keras versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants