Remove file level docstrings #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pet peeve. These are inconsistent, usually just a rephrase of the file itself, and keras-core isn't doing them. Who doesn't like less code? We can keep out class/function docstrings as the place to focus on.
ianstenbit
reviewed
Aug 21, 2023
| @@ -11,6 +11,7 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
There was a problem hiding this comment.
Are all these new blank lines intentional? Version change in linter?
There was a problem hiding this comment.
Ooh this must be some find-replace shenanigans 😛
There was a problem hiding this comment.
Either way looks like it makes these files consistent with the rest so LGTM
There was a problem hiding this comment.
Yeah, we were not consistent, nor did our lint check. This was just a little script I wrote. No strong opinion on newline after copyright block or not.
ianstenbit
approved these changes
Aug 21, 2023
| @@ -11,6 +11,7 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
There was a problem hiding this comment.
Either way looks like it makes these files consistent with the rest so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pet peeve. These are inconsistent, usually just a rephrase of the file itself, and keras-core isn't doing them.
Let's ditch filename docstring (unless they actually say something interesting). We can keep out class/function docstrings as the place to focus on.