Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start_index argument to all position embedding layers #1209

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add start_index argument to all position embedding layers #1209

merged 2 commits into from
Aug 15, 2023

Conversation

mattdangerw
Copy link
Member

This will allow all the layers to be used in a decoding context.

@mattdangerw
Copy link
Member Author

/gcbrun

ianstenbit
ianstenbit approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- might be worth some docstrings though!

keras_nlp/layers/modeling/rotary_embedding.py Show resolved Hide resolved
@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw mattdangerw merged commit 43cf146 into keras-team:master Aug 15, 2023
9 checks passed
@shivance shivance mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianstenbit ianstenbit ianstenbit approved these changes

@jbischof jbischof Awaiting requested review from jbischof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @ianstenbit