-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Faster R-CNN to Keras3 #2458
Port Faster R-CNN to Keras3 #2458
Conversation
Can we make last dimension of the |
@VarunS1997 Review for any corrections are fixes required from based code. Thanks! |
Hey @sineeli this is so cool! Thanks for taking this up. It was a long time ago and unfortunately I would not be able to give you a thorough review. What I understand should be green flags are:
Last I worked on it I could not get every component to comply with the Functional API. If you got that part sorted, you are good to go ^_^ Closes #2012 |
Yes trying to make it functional, hopefully it will workout! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, good ideas here and good implementation.
We should definitely, however, implement some of the requested changes.
Also please remember to run keras_cv's linter included under the shell/
directory.
I also will have to come back to this for architecture verification. But, if you have a working colab or similar, that would work as well.
keras_cv/src/models/object_detection/faster_rcnn/feature_pyramid.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py
Outdated
Show resolved
Hide resolved
…g for model saving
- Fix ROI Align ops for torch backend
- Make bounding box test utils use 256,256 image size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments to reduce tests sizes.
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py
Outdated
Show resolved
Hide resolved
- Add build method for fpn
- Correct YOLOv8 preset test case
Excellent work!! Thanks Siva!! |
FasterRCNN has been handed off to Divya.
What does this PR do?
Port legacy Faster R-CNN to Keras 3
Fix minor bug in ROI Align, make sure to build the shapes for each layer components.
The present PR is modified code of Updating FasterRCNN to use Task API contributed by @ariG23498. Please @ariG23498 any suggestions form your side are appreciated.