Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow different types of res_iter #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafis
Copy link

@rafis rafis commented Oct 8, 2013

Currently WSAPI accepts only function iterator as res_iter. This forces WSAPI frameworks and applications writers to return function iterator from their run(). Following code change allows users to use four different types of iterator: function, thread, table, string.

There is also small change for strictier check of not res to type(res) ~= "string", so for example if iterator returns some boolean true or table, it will no go to lfcgi.write() raising error at luaL_checklstring(), because it is not WSAPI error, it is application's error, application should return only strings from res_iter!

@hishamhm
Copy link
Member

Looks like this is fully backwards compatible, right? Could you update the code so it merges cleanly?

@ignacio ignacio mentioned this pull request Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants