Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React compiler plugin #83

Closed
wants to merge 1 commit into from
Closed

Conversation

billyjanitsch
Copy link
Collaborator

React now recommends that all projects enable the new compiler linter plugin, although it's still in beta. This doesn't mean enabling the compiler itself, it's just a lint rule to catch React rule violations that will cause the compiler to de-opt (and potentially otherwise cause bugs).

I have a few hesitations about including this in our standard config:

  1. Because it's still a prerelease, we'd pin to an exact version, which means that we'd need to update it frequently. So maybe our projects should depend on it directly and add it to their config manually until there's a stable release?
  2. It depends on Babel under the hood, which we've just moved away from. OTOH, the compiler itself is currently also implemented as a Babel plugin so we'll have to reintroduce Babel anyway to use the compiler. This is unfortunate but there's not much we can do about it; hopefully they release alternative bindings in the future.

Putting this up for feedback.

@billyjanitsch billyjanitsch requested a review from a team as a code owner November 14, 2024 20:20
@billyjanitsch
Copy link
Collaborator Author

We've decided for now to inline this in individual projects until it's out of prerelease.

@billyjanitsch billyjanitsch deleted the billy/react-compiler branch November 25, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant