Skip to content

Merge pull request #65 from afh/pic-init #22

Merge pull request #65 from afh/pic-init

Merge pull request #65 from afh/pic-init #22

GitHub Actions / clippy succeeded Jul 3, 2024 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 61 in src/render/pic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `write!()` with a format string that ends in a single newline

warning: using `write!()` with a format string that ends in a single newline
  --> src/render/pic.rs:61:9
   |
61 |         write!(self.pic, "p({left},{top},{width},{height})\n").unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
   = note: `#[warn(clippy::write_with_newline)]` on by default
help: use `writeln!` instead
   |
61 -         write!(self.pic, "p({left},{top},{width},{height})\n").unwrap();
61 +         writeln!(self.pic, "p({left},{top},{width},{height})").unwrap();
   |

Check warning on line 64 in src/render/pic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
  --> src/render/pic.rs:64:19
   |
64 |     fn into_image(mut self) -> String {
   |                   ----^^^^
   |                   |
   |                   help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default