Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump exception_page shard to version ~> 0.5.0 #693

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Bump exception_page shard to version ~> 0.5.0 #693

merged 2 commits into from
Oct 28, 2024

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Oct 27, 2024

SSIA

sdogruyol
sdogruyol approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Sija 🙏

@sdogruyol sdogruyol merged commit 749c537 into kemalcr:master Oct 28, 2024
9 checks passed
@Sija
Copy link
Contributor Author

Sija commented Oct 30, 2024

This IMO needs to go into v1.7, since it's a breaking change (removal of ExceptionPage.for_runtime_exception)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @sdogruyol