Update CI for Windows

kemalcr · Sep 30, 2024 · 28c1b02 · 28c1b02
1 parent b820a1d
commit 28c1b02
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 23 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,2 @@
+*.cr text eol=lf
+*.ecr text eol=lf
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,31 +11,66 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         crystal: [latest, nightly]
     runs-on: ${{ matrix.os }}
 
     steps:
       - name: Install Crystal
-        uses: oprypin/install-crystal@v1
+        uses: crystal-lang/install-crystal@v1
         with:
           crystal: ${{ matrix.crystal }}
 
       - name: Download source
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install dependencies
         run: shards install
-        env:
-          SHARDS_OPTS: --ignore-crystal-version
 
       - name: Run specs
         run: |
           crystal spec
-          crystal spec --release --no-debug
+
+  format:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+        crystal: [latest, nightly]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - name: Install Crystal
+        uses: crystal-lang/install-crystal@v1
+        with:
+          crystal: ${{ matrix.crystal }}
+
+      - name: Download source
+        uses: actions/checkout@v4
 
       - name: Check formatting
         run: crystal tool format --check
+
+  ameba:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+        crystal: [latest]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - name: Install Crystal
+        uses: crystal-lang/install-crystal@v1
+        with:
+          crystal: ${{ matrix.crystal }}
+
+      - name: Download source
+        uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: shards install
 
       - name: Run ameba linter
         run: bin/ameba
+
diff --git a/spec/helpers_spec.cr b/spec/helpers_spec.cr
@@ -108,12 +108,7 @@ describe "Macros" do
       response.status_code.should eq(200)
 
       response.headers["Content-Type"].should eq("application/octet-stream")
-
-      {% if flag?(:windows) %}
-        response.headers["Content-Length"].should eq("19")
-      {% else %}
-        response.headers["Content-Length"].should eq("18")
-      {% end %}
+      response.headers["Content-Length"].should eq("18")
     end
 
     it "sends file with given path and given mime-type" do
@@ -125,12 +120,7 @@ describe "Macros" do
       response = call_request_on_app(request)
       response.status_code.should eq(200)
       response.headers["Content-Type"].should eq("image/jpeg")
-
-      {% if flag?(:windows) %}
-        response.headers["Content-Length"].should eq("19")
-      {% else %}
-        response.headers["Content-Length"].should eq("18")
-      {% end %}
+      response.headers["Content-Length"].should eq("18")
     end
 
     it "sends file with binary stream" do

diff --git a/spec/view_spec.cr b/spec/view_spec.cr
@@ -22,11 +22,7 @@ describe "Views" do
     end
     request = HTTP::Request.new("GET", "/view/world")
     client_response = call_request_on_app(request)
-    {% if flag?(:windows) %}
-      client_response.body.strip.should eq("<html>Hello world\r\n</html>")
-    {% else %}
-      client_response.body.strip.should eq("<html>Hello world\n</html>")
-    {% end %}
+    client_response.body.strip.should eq("<html>Hello world\n</html>")
   end
 
   it "renders layout" do