Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Wiki into Sidebar #1864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

campavao
Copy link
Contributor

Ok definitely pull this down and review this before merging.

With this PR I updated the Wiki to open within the Sidebar rather than in a modal. Idea is two-fold:

  1. Can now keep the sidebar wiki pinned open during game
  2. Wiki is now mobile responsive

I wanted to make this update because there are many times where I want to search something during the match and the wiki modal can sometimes take too long to load while blocking my entire screen.

Some other updates bundled with this:

  • Pokemon section no longer uses Tabs and instead uses select dropdowns
  • Pokemon section also has been cleaned up a bit
    • Now when viewing a single pokemon, you no longer see duplicate information
    • When viewing a single pokemon, the rest of the list of pokemon in that category disappears and is replaced by a clear button
  • Abilities section now has a search bar where you can search the ability name or a pokemon that has that ability. This search is debounced to help performance while typing

Other sections have had images scaled down. Future improvements I'd like to make are:

  • give Regions, Weather, and Synergies a search bar to search similarly to Abilities section
  • update Synergies to get rid of Tabs and use select

I'm not totally sure, but I feel like Tabs might be resulting in some performance issues across the board. I know it's used widely and I don't totally have concrete proof other than the Pokemons section seems to be a bit faster now without it.

I did leave a lot of the old code for the modal wiki. I think in areas like the lobby it might make sense to use the modal, but I do like the aspect of being able to interact with the chat and join a game quickly with the wiki opened.

wiki-sidebar-1.mp4
wiki-sidebar-2.mp4
wiki-sidebar-3.mp4
wiki-sidebar-4.mp4

@keldaan-ag keldaan-ag added the enhancement New feature or request label Aug 14, 2024
@zBrodie
Copy link
Contributor

zBrodie commented Aug 27, 2024

Being able to have the wiki open to the items page would be very very useful for new players. Is it possible to add a full screen button that opens the old Wiki layout?

@campavao
Copy link
Contributor Author

Being able to have the wiki open to the items page would be very very useful for new players. Is it possible to add a full screen button that opens the old Wiki layout?

Glad you think so! I was planning on supporting the old way as well but just haven't found the time yet. I'll try to come back to this though if there's some interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants