Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Local pusher & alert feed #2484

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix: Local pusher & alert feed #2484

merged 4 commits into from
Nov 14, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Nov 14, 2024 •
edited
Loading

  1. Seems like https://github.com/keephq/keep/pull/2253/files#diff-008fb887e8276618c51329f01feb3092bbc660c780709c1c8beb9d1ebf831c49R28 prevented local & dev envs from connecting to Pusher
  2. We didn't trigger poll-alerts so alert feed was not live

Closes #2487

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:03pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working labels Nov 14, 2024
@Matvey-Kuk Matvey-Kuk changed the title WIP: Debugging pusher fix: Local pusher & alert feed Nov 14, 2024
@Matvey-Kuk Matvey-Kuk mentioned this pull request Nov 14, 2024
Closed
@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) November 14, 2024 15:54
VladimirFilonov
VladimirFilonov approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@Matvey-Kuk Matvey-Kuk merged commit 4f6b0b4 into main Nov 14, 2024
11 of 12 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/pusher-debug branch November 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirFilonov VladimirFilonov VladimirFilonov approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: Local pusher & alert feed
2 participants
@Matvey-Kuk @VladimirFilonov