Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract base64 images from placeholder #2477

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Nov 13, 2024

Closes #2476

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 3:24pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 13, 2024
@Kiryous Kiryous changed the title fix: extract base64 images from placeholder to not to process giant b… fix: extract base64 images from placeholder Nov 13, 2024
@dosubot dosubot bot added the Bug Something isn't working label Nov 13, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@Kiryous Kiryous merged commit 76dbd7b into main Nov 13, 2024
10 checks passed
@Kiryous Kiryous deleted the fix/2476-extract-base-64-rules-placeholder branch November 13, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore]: avoid processing giant base64 during build
2 participants