Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add sentry to keep-ui #2416

Merged
merged 18 commits into from
Nov 13, 2024
Merged

chore: add sentry to keep-ui #2416

merged 18 commits into from
Nov 13, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Nov 7, 2024

Closes #2415

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:16pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues labels Nov 7, 2024
@Kiryous
fix: middleware matcher
8292727 
(cherry picked from commit 873fc26)
talboren
talboren previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@talboren talboren self-requested a review November 13, 2024 13:02
talboren
talboren approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kiryous Kiryous merged commit 48f5a54 into main Nov 13, 2024
10 checks passed
@Kiryous Kiryous deleted the chore/2415-sentry-keep-ui branch November 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

@shahargl shahargl Awaiting requested review from shahargl

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ chore ]: add sentry to keep-ui
2 participants
@Kiryous @talboren