-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User can set exact provider log level using environment variable #2169
feat: User can set exact provider log level using environment variable #2169
Conversation
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ 1 Skipped Deployment
|
c9e8361
to
07ae457
Compare
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
- Coverage 71.20% 70.77% -0.43%
==========================================
Files 154 156 +2
Lines 14046 14250 +204
==========================================
+ Hits 10002 10086 +84
- Misses 4044 4164 +120 โ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why are we using this in BaseProvider:
self.logger = context_manager.get_logger()
and not
self.logger = logging.getLogger(__name__)
(I guess it's for automatic context, which can be achieved in other ways too)
But the easiest way to achieve what we're doing here in a "safer" way, is to have some way to add configuration to our logger via environment variables in logging.py
cc @shahargl @VladimirFilonov wdyt?
โฆP_PROVIDER_{}_LOG_LEVEL`
c625430
to
3596efd
Compare
โฆ-level-via-provider_provider_name_log_level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
๐ Incredible, @VladimirFilonov! You've merged your 28th PR! ๐ฏ๐ Your ongoing commitment to keep is truly remarkable. You're a driving force in our community! ๐ @talboren and the entire team are grateful for your dedication. You're an inspiration to us all! ๐ซ |
Closes #2149
๐ Description
Variable name:
KEEP_PROVIDER_{}_LOG_LEVEL
โ Checks
โน Additional Information