refactor pin flow #141
Open
refactor pin flow #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sajalbnl
commented
Jan 20, 2025
sajalbnl
commented
- issue [feat] refactor pin flow #140
- follows contribution guide
- code change includes tests
- breaking change
trbutler4
reviewed
Jan 23, 2025
| @@ -59,8 +62,7 @@ fun WalletApp(tokenViewModel: TokenViewModel) { | |||
| hasAccountState.value?.let { hasAccount -> | |||
| WalletappTheme { | |||
|
|
|||
|
|
|||
| val startDestination = if (hasAccount) Wallet else Onboarding | |||
There was a problem hiding this comment.
this should require pin input if the pin has been set, not pin creation. A hash of the pin should be added to the WalletStoreModule once the pin has been created.
trbutler4
reviewed
Jan 23, 2025
| unfocusedTextColor = Color.White | ||
| ) | ||
| ) | ||
| // PasscodeCircles(passcode, hiddenPasscode, maxDigits) |
There was a problem hiding this comment.
just delete code instead of commenting it out
trbutler4
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Creating the pin should happen as part of the onboarding flow. There should be an additional pin input locking the wallet screen (or just two screens: pin input screen, and then redirect to wallet screen). This just prompts the user to create a pin if they already have an account.
Let me know if you have any questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.