Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler CLI command naming, minor docs inconsistencies and deploy_v1 fix #259

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

m-kus
Copy link
Contributor

@m-kus m-kus commented Nov 30, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

  • Readme and docs are slightly inconsistent in cli command names
  • Currently deploying verifier contract with fees in eth fails because the mandatory abi parameter is missing.

What is the new behavior?

  • Inconsistencies are resolved
  • deploying verifier contract with fees paid in eth works without errors

Does this introduce a breaking change?

  • Yes
  • No

Other information

Why eth and not strk: the original problem is that public faucets provide more eth than strk, and since garaga contracts are quite costly, the amount of strk you can get from faucets is not enough to deploy/interact. Although this is a separate issue that will hopefully get fixed, I think it makes sense to support paying fees in eth for all garaga interactions anyways.

There is also a commit that enables paying fees in eth for proof verification — that's changes from #256, if that PR is merged I can remove the commit.

@m-kus m-kus requested a review from feltroidprime as a code owner November 30, 2024 13:05
@feltroidprime feltroidprime changed the title Minor docs inconsistencies and deploy_v1 fix Simpler CLI command naming, minor docs inconsistencies and deploy_v1 fix Dec 2, 2024
@feltroidprime feltroidprime merged commit 5f3b232 into main Dec 2, 2024
27 checks passed
@feltroidprime feltroidprime deleted the fix/minor-docs-inconsistencies branch December 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants