Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_groth16_calldata to npm package #250

Merged
merged 17 commits into from
Nov 3, 2024

Conversation

luiz-lvj
Copy link
Collaborator

Adding get_groth16_calldata (in rust) to npm package

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

The npm package doesn't support the function get_groth16_calldata

Issue Number: #244

What is the new behavior?

  • Funcion get_groth16_calldata from garaga_rs binded to wasm pkg and npm package
  • Tests running on test-integration-suit

Does this introduce a breaking change?

  • Yes
  • No

Other information

@feltroidprime
Copy link
Collaborator

Looks good, but can we combine the parsing test on all the example json files available and just trying generating the calldata for them ?

We don't need to hardcode the inputs or expected output, simply a test that parses the proofs + vk and call the calldata generator without crashing will be enough to validate it is working.

Thank you

@feltroidprime feltroidprime merged commit 1748393 into keep-starknet-strange:main Nov 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants