-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override default_run_env instead of base_env #75
Conversation
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I understood correctly, now the base environment will always be base
, and the action/button changes the run environment, right? And the default would be local
?
This makes more sense 👍🏼 Would the user still have the option to set the run env to base
?
Signed-off-by: Nok Lam Chan <[email protected]>
I think |
For the record we agree on above in private discussion. |
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
I swear I fixed it before, but apparent I didn't.
In Kedro, the two environments work as:
base
local
.If user is changing to
prod
environment, it should bebase
+prod
instead ofprod
+local
(current status).For example,
kedro run --env=prod
is equivalent tobase_env='base', run_env='prod'
The starting status bar now look like this:
Dev Notes
Select Kedro Run environment
instead of basebase + local
. It's not possible to changebase
environment via the extension. This is consistent to how Kedro CLI works too. It's rare one need to change base_env.base
, as otherwise it will becomebase + base
. We discussed briefly there may be user want to use a single environment, but we are not sure if this requirement exists, so we didn't implement this and will wait for FR instead.