Remove lsClient from webview request #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok Lam Chan <[email protected]>
noklam
commented
Aug 21, 2024
Comment on lines
+153
to
+154
| registerCommand('kedro.sendDefinitionRequest', async (word) => { | ||
| await executeServerDefinitionCommand(lsClient, word); |
There was a problem hiding this comment.
The idea is that the webview use vscode command directly, instead of importing any function.
The command itself would have access of lsClient already. This enable restart LSP without disconnecting the webview from it.
noklam
commented
Aug 21, 2024
Comment on lines
+34
to
+38
| export async function getlsClient() { | ||
| return lsClient; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
not needed, will clean up
|
I need to test it tomorrow as I discover a bug in the LSP which causing it to find the incorrect config. But I test this so the restart of LSP can continue work with the webview. |
jitu5
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.