Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2048
If you hit https://demo.kedro.org/experiment-tracking directly it give 404 page, This PR address it by introducing functionality to handle GitHub Pages redirects by storing the requested path and redirecting to the root. The changes include updates to the
404.html
file and modifications to theFlowChartWrapper
component to manage the redirect process.Note: This approach do not need
hashRouter
Development notes
Redirect handling:
public/404.html
: Added a script to store the requested path inlocalStorage
and redirect to the root. If an error occurs, it falls back to redirecting to the root.FlowChartWrapper component updates:
src/components/flowchart-wrapper/flowchart-wrapper.js
: Added auseEffect
hook to check for a stored path inlocalStorage
and navigate to it if present.src/components/flowchart-wrapper/flowchart-wrapper.js
: Updated theuseEffect
hook to remove the stored path after processing the redirect or set parameters from local storage if no redirect path is found.QA notes
I have deployed the changes to Github pages https://jitu5.github.io to test.
Checklist
RELEASE.md
file