Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Github pages 404 issue #2179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle Github pages 404 issue #2179

wants to merge 2 commits into from

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Nov 7, 2024

Description

Resolves #2048

If you hit https://demo.kedro.org/experiment-tracking directly it give 404 page, This PR address it by introducing functionality to handle GitHub Pages redirects by storing the requested path and redirecting to the root. The changes include updates to the 404.html file and modifications to the FlowChartWrapper component to manage the redirect process.

Note: This approach do not need hashRouter

Development notes

Redirect handling:

  • public/404.html: Added a script to store the requested path in localStorage and redirect to the root. If an error occurs, it falls back to redirecting to the root.

FlowChartWrapper component updates:

QA notes

I have deployed the changes to Github pages https://jitu5.github.io to test.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 self-assigned this Nov 7, 2024
@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Nov 7, 2024
@jitu5 jitu5 marked this pull request as ready for review November 7, 2024 16:18
Signed-off-by: Jitendra Gundaniya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Access to Experiment Tracking Causes 404 Error on viz demo
1 participant