Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for lite mode and support earliest Kedro version #2148

Merged
merged 23 commits into from
Oct 25, 2024
Merged

Add e2e test for lite mode and support earliest Kedro version #2148

merged 23 commits into from
Oct 25, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Oct 22, 2024 •
edited
Loading

Description

Resolves #2103

Development notes

  • Add e2e test scenario for kedro viz --lite and kedro 0.18.3
  • Update import statements to support earliest kedro versions

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
sync remote
8830cab
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
0a5d1ae
@ravi-kumar-pilla
merge main
bf47b47
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
13e905b
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
3d6326c
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
3d3bdda
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1abfc43
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1461a3c
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
c3f7cc6
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1831a39
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
db14971
@ravi-kumar-pilla
merge main
93a7e28
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
a7592a2
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
493f5d1
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ab8a6b1
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
f715fdf
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
27c38dc
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
16a0435
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
5ccafb6
@ravi-kumar-pilla
add lite support for kedro 18 and add e2e test
edbca63
@ravi-kumar-pilla
fix perm
4d1e5eb
@ravi-kumar-pilla
use hasattr
3485da7
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review October 23, 2024 13:08
SajidAlamQB
SajidAlamQB approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravi-kumar-pilla, LGTM.

rashidakanchwala
rashidakanchwala approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rashidakanchwala rashidakanchwala merged commit 712c5cf into main Oct 25, 2024
19 checks passed
@rashidakanchwala rashidakanchwala deleted the chore/e2e-lite-test branch October 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@jitu5 jitu5 jitu5 approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e tests for kedro viz --lite and relevant unit tests
4 participants
@ravi-kumar-pilla @rashidakanchwala @jitu5 @SajidAlamQB