-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for scaling based on Redis Key-Values #6276
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: wangrushen <[email protected]>
a50770f
to
91ae8d1
Compare
Signed-off-by: wangrushen <[email protected]>
/run-e2e redis |
Signed-off-by: wangrushen <[email protected]>
/run-e2e redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ❤️ , only a small comment inline
tests/scalers/redis/redis_sentinel_strings/redis_sentinel_strings_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: wangrushen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zbynek Roubalik <[email protected]>
Let's wait for resolution on docs: kedacore/keda-docs#1493 (comment) |
Supoort scaling based on Redis Key-Values
Checklist
Fixes #5003
Relates to #