Add azure-workload auth to MSSQL scaler #6161
Conversation
rickbrouwer
force-pushed
the
mssql
branch
8 times, most recently
from
877148b
to
e253199
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rickbrouwer
force-pushed
the
mssql
branch
19 times, most recently
from
633987e
to
8cd724e
Compare
rickbrouwer
force-pushed
the
mssql
branch
5 times, most recently
from
dfbdac2
to
5a08a0d
Compare
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
mssql
branch
6 times, most recently
from
783dd2d
to
a7d0e2c
Compare
Signed-off-by: rickbrouwer <[email protected]>
|
Hi @tomkerkhove I was refactoring the MSSQL scaler to match the new metadata guidelines. I thought I would also nice to add the requested Azure workload feature. I do not work with Azure myself and I mainly have to rely on reading about it. The unittest is successful, but I would like to see this very well checked. Could you check this PR? If I'm completely off track I could also leave it at just refactoring. |
|
Thanks a ton! Sadly, I don't do code contributions here so maybe @kedacore/keda-contributors can help with review |
|
Hi @pauldotyu! I saw that you did a lot of work for the Azure workload identity, for example with the RabbitMQ. I was refactoring the MSSQL scaler to match the new metadata guidelines. I thought I would also nice to add the #6104 Azure workload feature. I do not work with Azure myself and I mainly have to rely on reading about it. The unittest is successful, but I would like to see this very well checked. Is this something you can look into? If I'm completely off track, please let me know. |
|
Let's not poke random people and wait for the group that I have mentioned please =) |
|
Also, if the PR is ready for review - Please publish it. Draft PRs are typically WIP PRs |
rickbrouwer
changed the title
my sincere apologies |
|
No worries |
|
/run-e2e * |
|
I think that we could cover this with e2e test as we have an Azure subscription. Could you open a PR to the testing infra repo to spin up and configure the database? |
Is a feature request in https://github.com/kedacore/testing-infrastructure ok? |
yes 😄 |
|
The testing infrastructure has to be deployed but @rickbrouwer needs help with that and I've not had time yet |
Checklist
Fixes #6104
Relates to #5797