-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the token-permission and pinned dependencies issue #6088
Open
harshitasao
wants to merge
1
commit into
kedacore:main
Choose a base branch
from
harshitasao:scorecard-checks-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ on: | |
issues: | ||
types: | ||
- opened | ||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
track_issue: | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,12 +69,15 @@ jobs: | |
run: make test | ||
|
||
- name: Create test Summary | ||
uses: test-summary/action@v2 | ||
uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86 # v2.4 | ||
with: | ||
paths: "report.xml" | ||
if: always() | ||
|
||
validate-dockerfiles: | ||
permissions: | ||
contents: read # for dorny/paths-filter to fetch a list of changed files | ||
pull-requests: read # for dorny/paths-filter to read pull requests | ||
name: validate-dockerfiles - ${{ matrix.name }} | ||
runs-on: ${{ matrix.runner }} | ||
container: ghcr.io/kedacore/keda-tools:1.22.5 | ||
|
@@ -106,6 +109,9 @@ jobs: | |
run: make docker-build | ||
|
||
validate-dev-container: | ||
permissions: | ||
contents: read # for dorny/paths-filter to fetch a list of changed files | ||
pull-requests: read # for dorny/paths-filter to read pull requests | ||
name: Validate dev-container - ${{ matrix.name }} | ||
runs-on: ${{ matrix.runner }} | ||
container: ghcr.io/kedacore/keda-tools:1.22.5 | ||
|
@@ -146,7 +152,7 @@ jobs: | |
go-version: "1.22" | ||
- name: Get golangci | ||
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.59.1 | ||
- uses: pre-commit/[email protected] | ||
- uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507 # v3.0.0 | ||
|
||
trivy-scan: | ||
uses: kedacore/keda/.github/workflows/template-trivy-scan.yml@main | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ on: | |
push: | ||
tags: | ||
- 'v*' | ||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
build: | ||
name: Push Release | ||
|
@@ -44,7 +47,7 @@ jobs: | |
run: go mod tidy -compat=1.22 | ||
|
||
- name: Login to GitHub Container Registry | ||
uses: docker/login-action@v3 | ||
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0 | ||
with: | ||
# Username used to log in to a Docker registry. If not set then no login will occur | ||
username: ${{ github.repository_owner }} | ||
|
@@ -63,7 +66,7 @@ jobs: | |
VERSION: ${{ steps.get_version.outputs.VERSION }} | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1 | ||
|
||
- name: Publish KEDA images on GitHub Container Registry | ||
run: make publish-multiarch | ||
|
@@ -72,7 +75,7 @@ jobs: | |
|
||
# https://github.com/sigstore/cosign-installer | ||
- name: Install Cosign | ||
uses: sigstore/cosign-installer@v3 | ||
uses: sigstore/cosign-installer@59acb6260d9c0ba8f4a2f9d9b48431a222b68e20 # v3.5.0 | ||
|
||
- name: Check Cosign install! | ||
run: cosign version | ||
|
@@ -87,7 +90,7 @@ jobs: | |
# Get release information to determine id of the current release | ||
- name: Get Release | ||
id: get-release-info | ||
uses: bruceadams/[email protected] | ||
uses: bruceadams/get-release@74c3d60f5a28f358ccf241a00c9021ea16f0569f # v1.3.2 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,9 @@ on: | |
kindImage: | ||
required: true | ||
type: string | ||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
smoke-tests: | ||
name: Validate k8s-${{ inputs.kubernetesVersion }} | ||
|
@@ -35,7 +38,7 @@ jobs: | |
fetch-depth: 1 | ||
|
||
- name: Create k8s ${{ inputs.kubernetesVersion }} Kind Cluster | ||
uses: helm/[email protected] | ||
uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||
with: | ||
node_image: ${{ inputs.kindImage }} | ||
cluster_name: smoke-tests-cluster-${{ inputs.kubernetesVersion }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ on: | |
push: | ||
branches: | ||
- v1 | ||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
validate: | ||
name: Validate | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's improve it to make it more clear.
Also, please move this under improvements as this is not a fix for KEDA itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the
Other
section please