-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requireAllDemandsAndIgnoreOthers flag #5839
base: main
Are you sure you want to change the base?
Conversation
Semgrep found 1 Consider to use well-defined context Ignore this finding from context-todo.Semgrep found 1 Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Ignore this finding from no-direct-write-to-responsewriter. |
…mandsAndIgnoreOthers
Semgrep found 1 Consider to use well-defined context Ignore this finding from context-todo.Semgrep found 1 Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Ignore this finding from no-direct-write-to-responsewriter. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the DCO check and update the changelog too?
/run-e2e pipeline |
Semgrep found 1 Consider to use well-defined context Ignore this finding from context-todo.Semgrep found 1 Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Ignore this finding from no-direct-write-to-responsewriter. |
This PR adds an extra option
requireAllDemandsAndIgnoreOthers
(name tbd) to the azure pipeline scaler which ensures that all demands in the scaler definition is present in the incoming job, while ignoring any other demands the job may have.This is different from
requireAllDemands
which requires all demands to be an exact match.Checklist
When introducing a new scaler, I agree with the scaling governance policyA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)Fixes #5579