Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo and other dependencies #403

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

MonterraByte
Copy link
Contributor

@MonterraByte MonterraByte commented Oct 3, 2024

Resolves #402. Resolves #401. Resolves #384. Resolves #404.

This MR updates all dependencies to their latest versions. The only update that required code changes was the cargo crate, which was caused by:

  • cargo::util::Config being renamed to cargo::util::context::GlobalContext.
  • cargo::sources::source::Source::query_vec() returning a Vec<IndexSummary> instead of a Vec<Summary>.

Cargo.toml Outdated Show resolved Hide resolved
@BarbossHack
Copy link

BarbossHack commented Oct 5, 2024

Also Fixes #385

@MonterraByte
Copy link
Contributor Author

Also Fixes #385

That one is already fixed in master, as far as I can tell.

@kaimast
Copy link

kaimast commented Oct 17, 2024

Maybe bump directly to cargo 0.83?

@MonterraByte
Copy link
Contributor Author

Maybe bump directly to cargo 0.83?

That wasn't out when I made the PR. :)
I'll update it.

@kaimast
Copy link

kaimast commented Oct 17, 2024

Yeah, I figured it might not have been out yet.

I just tried the PR, and it works fine for me. Thanks for creating it! Hopefully, the maintainers can merge it soon.

@zerosnacks
Copy link

zerosnacks commented Oct 29, 2024

Ping @kbknapp, install currently throws - should be resolved by this PR:

error[E0282]: type annotations needed for `Box<_>`
  --> /home/<USER>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update

@kbknapp
Copy link
Owner

kbknapp commented Nov 28, 2024

Hi all. Sorry for the lack of communication. It's been a very crazy year for me. I'm open to adding maintainer to this project if anyone is willing as i think the other current maintainers are in a similar situation. Feel free to email me and I can review your account and/or other contributions. I'd plan on keeping this repo here, to try and keep an eye on new maintainers as best I can. However, if the Rust or Cargo project wished me to transfer to their control as has been discussed previously, I'd be open to that too.

@MonterraByte MonterraByte force-pushed the cargo-update branch 2 times, most recently from c40f1ad to 52da5b1 Compare November 28, 2024 21:33
@kbknapp
Copy link
Owner

kbknapp commented Dec 3, 2024

All, @davidhewitt has graciously offered to help get some PRs through and help with releases. I also approved the CI to run on this MR, looks like the MSRV may have changed which is fine but will require bumping it in CI as well.

@fredrik-jansson-se
Copy link

Thanks everyone for keeping this awesome project alive!!

@rchildre3
Copy link

also bump MSRV in .github/workflows/lint.yml in MSRV Check job?

This updates the `time` dependency, fixing a build error
with Rust >= 1.80.0.
git2-curl is also updated to v0.20.0 to satisfy dependency constraints.
@MonterraByte
Copy link
Contributor Author

also bump MSRV in .github/workflows/lint.yml in MSRV Check job?

Done.

@davidhewitt
Copy link
Collaborator

This looks good to me, I'll merge this and work out how to get a new release published shortly. Thanks all!

@davidhewitt davidhewitt merged commit 0d5f4a7 into kbknapp:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants