Enable payloads for non coinbase transactions

[someone235]

Simpa results

cargo run --release --bin simpa -- --testnet11 -t=5 -n=10000 --long-payload
2024-11-10 17:33:06.044+00:00 [INFO ] Total validation time: 22.023479023s, block processing rate: 454.06 (b/s), transaction processing rate: 2479.35 (t/s)

cargo run --release --bin simpa -- --testnet11 -n=10000
2024-11-10 17:38:16.827+00:00 [INFO ] Total validation time: 14.898869473s, block processing rate: 671.19 (b/s), transaction processing rate: 30463.32 (t/s)

TODO:

• Make a test for activation logic
• Make sure txid, txhash and sighash are affected by payload change (maybe we already have tests that verify it, we need to check)
• Search for TODOs related to payloads in the codebase and apply them if needed
• Check perf bottlenecks (Maybe the problem is somehow unique to simpa?)
• Make benchmark for validating a transaction with many inputs and large payloads
• Launch a network, where txgen creates txns with long payload, and check how the network handles it

[michaelsutton]

Note the implementation of sighash::payload_hash which currently ignores the payload, as well as the TODO within (reused values)

[someone235]

Note the implementation of sighash::payload_hash which currently ignores the payload, as well as the TODO within (reused values)

Added to TODOs