-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UTXO Return Address RPC command #436
Open
coderofstuff
wants to merge
18
commits into
kaspanet:master
Choose a base branch
from
coderofstuff:utxo-retaddr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderofstuff
force-pushed
the
utxo-retaddr
branch
2 times, most recently
from
March 22, 2024 05:40
a91193a
to
7d1b663
Compare
D-Stacks
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aspect
reviewed
Mar 22, 2024
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
March 28, 2024 16:26
393f432
to
e6de4c7
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
April 10, 2024 03:54
e6de4c7
to
71f66aa
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
July 25, 2024 04:58
71f66aa
to
8943d5a
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
July 25, 2024 05:05
8943d5a
to
9572f85
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
4 times, most recently
from
September 6, 2024 07:26
2273850
to
e384b16
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
September 6, 2024 07:27
e384b16
to
450f6fe
Compare
coderofstuff
force-pushed
the
utxo-retaddr
branch
from
September 6, 2024 07:43
450f6fe
to
6be25c4
Compare
Could we separate accepting block finder/iterator and return address finder on consensus to possibly allow |
michaelsutton
requested changes
Sep 29, 2024
- Refactor to multiple functions - Avoid unwrap as much as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifications
GetUtxoReturnAddress
txid: Hash
andaccepting_block_daa_score: u64
*Result<Address, ReturnAddressError>
**Notes
ReturnAddressError
.Proto