-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaspawallet: implement fee calcs, centralize constant and logic #2107
base: dev
Are you sure you want to change the base?
Conversation
D-Stacks
commented
Jun 26, 2022
•
edited
Loading
edited
- Move fee calcs, logic and constants to libkaspawallet
- Allow for functions to calculate transaction(s) fees
Codecov Report
@@ Coverage Diff @@
## dev #2107 +/- ##
==========================================
- Coverage 59.19% 59.10% -0.09%
==========================================
Files 678 679 +1
Lines 32831 32854 +23
==========================================
- Hits 19434 19419 -15
- Misses 10596 10629 +33
- Partials 2801 2806 +5
Continue to review full report at Codecov.
|
Converting back to draft: Makes more sense to optionally return the whole tx, this can be used by clients to send, and get tx data for post-analysis, no reason to limit this feature in the |
I will split this into two dependent prs, one for feecalcs, one for sending back whole tx data, seems to make the most sense. |