-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaspawalletd: Check validity of addresses in isolation #2105
Open
D-Stacks
wants to merge
8
commits into
kaspanet:dev
Choose a base branch
from
D-Stacks:Kaspawalletd--check-If-address-is-valid-kaspa-address
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kaspawalletd: Check validity of addresses in isolation #2105
D-Stacks
wants to merge
8
commits into
kaspanet:dev
from
D-Stacks:Kaspawalletd--check-If-address-is-valid-kaspa-address
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/D-Stacks/kaspad into Kaspawalletd--check-If-address-is-valid-kaspa-address
Codecov Report
@@ Coverage Diff @@
## dev #2105 +/- ##
==========================================
- Coverage 59.19% 59.11% -0.08%
==========================================
Files 678 678
Lines 32831 32858 +27
==========================================
- Hits 19434 19424 -10
- Misses 10596 10630 +34
- Partials 2801 2804 +3
Continue to review full report at Codecov.
|
D-Stacks
changed the title
kaspawalletd: check addresses validity in isolation
kaspawalletd: Check validity of addresses in isolation
Jun 25, 2022
D-Stacks
changed the title
kaspawalletd: Check validity of addresses in isolation
Kaspawalletd: Check validity of addresses in isolation
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested by our vitex gatekeeper, it allows the kaspawallet to check for address validity in isolation, as a safeguard so calls do not fail because of wrong address formating, and as a prerequisit opperation on vitex.