Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaspawalletd: Check validity of addresses in isolation #2105

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

D-Stacks
Copy link
Contributor

@D-Stacks D-Stacks commented Jun 24, 2022

This was requested by our vitex gatekeeper, it allows the kaspawallet to check for address validity in isolation, as a safeguard so calls do not fail because of wrong address formating, and as a prerequisit opperation on vitex.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #2105 (ff18846) into dev (b9093d5) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #2105      +/-   ##
==========================================
- Coverage   59.19%   59.11%   -0.08%     
==========================================
  Files         678      678              
  Lines       32831    32858      +27     
==========================================
- Hits        19434    19424      -10     
- Misses      10596    10630      +34     
- Partials     2801     2804       +3     
Impacted Files Coverage Δ
cmd/kaspawallet/daemon/server/address.go 0.00% <0.00%> (ø)
util/address.go 77.35% <0.00%> (-13.76%) ⬇️
...tructure/network/rpcclient/rpc_on_chain_changed.go 52.38% <0.00%> (-14.29%) ⬇️
infrastructure/network/netadapter/router/route.go 72.72% <0.00%> (-4.55%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 60.34% <0.00%> (-1.73%) ⬇️
infrastructure/network/addressmanager/store.go 77.84% <0.00%> (-1.27%) ⬇️
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 52.63% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9093d5...ff18846. Read the comment docs.

@D-Stacks D-Stacks changed the title kaspawalletd: check addresses validity in isolation kaspawalletd: Check validity of addresses in isolation Jun 25, 2022
@D-Stacks D-Stacks changed the title kaspawalletd: Check validity of addresses in isolation Kaspawalletd: Check validity of addresses in isolation Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant