reclaim testcases #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byteZorvin
commented
Aug 9, 2024
byteZorvin
commented
- This adds reclaim tests
apoorvsadana
reviewed
Aug 9, 2024
Comment on lines
+78
to
+81
| token_bridge.contract_address, | ||
| Event::DepostiCancelRequest(expected_deposit_cancel) | ||
| ), | ||
| (token_bridge.contract_address, Event::DepositReclaimed(expected_deposit_reclaim)) |
There was a problem hiding this comment.
looks like some formatting issue, is there any formatter right now? i know there's the new exploration project which started but there's nothing else for now?
There was a problem hiding this comment.
I have the formatter setup on my local, and even there is github action that validates the formatting of the code on every pr check here
|
|
||
| #[test] | ||
| #[should_panic(expected: ('CANCELLATION_NOT_ALLOWED_YET',))] | ||
| fn deposit_with_message_reclaim_delay_not_reached() { |
There was a problem hiding this comment.
let's also add this to the accept_deposit issue?
There was a problem hiding this comment.
Have added this to the issue #8
apoorvsadana
reviewed
Aug 9, 2024
Comment on lines
+37
to
+44
| let (token_bridge, mut spy, messaging_mock) = deploy_token_bridge_with_messaging(); | ||
| let usdc_address = deploy_erc20("usdc", "usdc"); | ||
| let usdc = IERC20Dispatcher { contract_address: usdc_address }; | ||
|
|
||
| enroll_token_and_settle(token_bridge, messaging_mock, usdc_address); | ||
|
|
||
| usdc.approve(token_bridge.contract_address, 100); | ||
| token_bridge.deposit(usdc_address, 100, snf::test_address()); |
There was a problem hiding this comment.
based on the deposit_ok PR, I think we can move this to a common function. but we can merge this one into deposit_ok first and then you can fix all things there?
There was a problem hiding this comment.
Yes makes sense, can be done in #6
* deactivate tc * send messages tc * change name * resolved comments * Update tests/withdrawal_limit_bridge_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> --------- Co-authored-by: Apoorv Sadana <[email protected]>
apoorvsadana
added a commit
that referenced
this pull request
Aug 13, 2024
* feat: initiliased testcases * admin function tests * fix: max total balance check * feat: block token test * disable limit test * feat: add failing tc for withdraw limit * fixed testcases after rebase * chore: added messaging mock * Update src/bridge/token_bridge.cairo Co-authored-by: Apoorv Sadana <[email protected]> * resolve comments * add reactivate and unblock * add reactivate and unblock * unblock tests * reactivate and unblock tests * resolved merge conflicts * restructure testcases * fix: visibility modifier * deposit tests * make them unit * make them unit * deposit flow tests * change to mock usdc address * improve: not needed to deploy usdc in while mock testing * unit testcases * add token actions restructure * migrate to latest foundry * restructure * deposit failing tc * test: happy withdraw test * chore: ran formatter * fix settlement of message * change deposit tests to use message_payloads * add assert * failing withdraw tc * cancel request * deposit with message cancels * Update tests/deposit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * resolved comments * fix consume message * fix consume message check * reclaim testcases (#7) * reclaim testcases * consume message * add balance check * add events in actions * Unit tests (#9) * deactivate tc * send messages tc * change name * resolved comments * Update tests/withdrawal_limit_bridge_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> --------- Co-authored-by: Apoorv Sadana <[email protected]> --------- Co-authored-by: Apoorv Sadana <[email protected]> * add setup functions --------- Co-authored-by: Apoorv Sadana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.