Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource-propagating.md #719

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

LavredisG
Copy link
Contributor

/kind documentation

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 18, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2024
@LavredisG
Copy link
Contributor Author

LavredisG commented Oct 18, 2024

/kind documentation

  1. Not totally sure about this PR because I can't quite understand the difference between ReplicaDivisionPreference.Aggregated and ReplicaDivisionPreference.Weighted.WeightPreference.DynamicWeight. Are they both based on cluster resource modeling (in that case why are there 2 same ways to divide replicas) or the second relies on the number of replicas already on the cluster (details on number 2)?

  2. From the example we read that "It means replicas will be propagated based on available replicas in member clusters . For example, the scheduler selected 3 clusters (A/B/C) and should divide 12 replicas to them. Based on cluster resource modeling , we get that the max available replicas of A, B, C is 6, 12, 18. Therefore, the weight of cluster A:B:C will be 6:12:18 (equal to 1:2:3). At last, the assignment would be "A: 2, B: 4, C: 6"." when the case is DynamicWeight, which actually states 2 ways that the propagation happens. Either based on available replicas (replicas already existing on the clusters) or based on cluster resosurce modeling (how many replicas can fit in the cluster). I inferred that the correct case was the one based on the cluster resource modeling so I rephrased the paragraph for this case.

@RainbowMango
Copy link
Member

Not totally sure about this PR because I can't quite understand the difference between ReplicaDivisionPreference.Aggregated and ReplicaDivisionPreference.Weighted.WeightPreference.DynamicWeight. Are they both based on cluster resource modeling (in that case why are there 2 same ways to divide replicas) or the second relies on the number of replicas already on the cluster (details on number 2)?

As described in the doc, the Aggregated means placing replicas in as few clusters as possible. Use cases include big data processing tasks where they prefer to run as much as possible within a single cluster to improve overall performance, but they can also tolerate replicas being distributed across multiple clusters.

The DynamicWeight applies to scenarios where administrators want to balance resource utilization across each cluster to avoid situations where some cluster are overloaded while others are underutilized.

@RainbowMango
Copy link
Member

when the case is DynamicWeight, which actually states 2 ways that the propagation happens. Either based on available replicas (replicas already existing on the clusters) or based on cluster resosurce modeling (how many replicas can fit in the cluster). I inferred that the correct case was the one based on the cluster resource modeling so I rephrased the paragraph for this case.

Yeah, thank you. You are right.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@karmada-bot karmada-bot merged commit 06d087e into karmada-io:main Oct 21, 2024
7 checks passed
@LavredisG
Copy link
Contributor Author

Not totally sure about this PR because I can't quite understand the difference between ReplicaDivisionPreference.Aggregated and ReplicaDivisionPreference.Weighted.WeightPreference.DynamicWeight. Are they both based on cluster resource modeling (in that case why are there 2 same ways to divide replicas) or the second relies on the number of replicas already on the cluster (details on number 2)?

As described in the doc, the Aggregated means placing replicas in as few clusters as possible. Use cases include big data processing tasks where they prefer to run as much as possible within a single cluster to improve overall performance, but they can also tolerate replicas being distributed across multiple clusters.

The DynamicWeight applies to scenarios where administrators want to balance resource utilization across each cluster to avoid situations where some cluster are overloaded while others are underutilized.

I see, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants