Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fieldoverrider docs #693

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

sophiefeifeifeiya
Copy link
Contributor

@sophiefeifeifeiya sophiefeifeifeiya commented Sep 30, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:
User Guide for field overrider.

Which issue(s) this PR fixes:
Fixes #699

Special notes for your reviewer:
None

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 30, 2024
@karmada-bot
Copy link
Collaborator

Welcome @sophiefeifeifeiya! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2024
@sophiefeifeifeiya sophiefeifeifeiya force-pushed the override-docs branch 2 times, most recently from f658ab8 to 2078224 Compare September 30, 2024 14:09
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -473,5 +474,58 @@ data:
example: 2
```

### FieldOverrider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to add the FieldOverrider ahead of PlaintextOverrider, just to keep consistent with the apply order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding. I changed it.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@karmada-bot karmada-bot merged commit 2ff0108 into karmada-io:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of documentation for field overrider
4 participants