Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong url in zh docs components.md #645

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented Jun 25, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
fix wrong url in zh docs

Which issue(s) this PR fixes:

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 25, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview still doesn't work for these links.

Please add your signature by running:

git commit -s --amend
git push -f

@windsonsea
Copy link
Member

奇怪,预览中这些 link 都不对:
https://deploy-preview-645--karmada.netlify.app/zh/docs/core-concepts/components/

@B1F030
Copy link
Contributor Author

B1F030 commented Jun 25, 2024

奇怪,预览中这些 link 都不对: https://deploy-preview-645--karmada.netlify.app/zh/docs/core-concepts/components/

我这边测试好像正常呀,next版本中,都能正常链接到中文文档的对应章节

@windsonsea
Copy link
Member

Thanks.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@karmada-bot karmada-bot merged commit fa124e5 into karmada-io:main Jun 26, 2024
7 checks passed
@B1F030 B1F030 deleted the patch-1 branch June 27, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants