Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the documentation to reflect deprecation of "external" profile value in istioctl #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update the documentation to reflect deprecation of "external" profile value in istioctl #620

wants to merge 2 commits into from

Conversation

devleejb
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:
This PR updates the documentation to reflect the deprecation of the "external" profile value in istioctl and its replacement with "remote" to align with the latest changes.

image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
windsonsea
windsonsea reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems --- has the same effect as ***:

Before | After

@devleejb
Copy link
Contributor Author

devleejb commented Jul 8, 2024

@windsonsea
Sorry, I don't understand.
Could you explain with some screenshots?

RainbowMango
RainbowMango reviewed Jul 12, 2024
View reviewed changes
docs/userguide/service/working-with-istio-on-non-flat-network.md
@@ -12,11 +12,13 @@ not direct connectivity between the pods in all clusters.
![Istio on Karmada-different-network](../../resources/userguide/service/istio/istio-on-karmada-different-network.png)

***
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why change this *** to ---, seems they are both used to add a new line.

I'm ok with it, it seems this one forgot to change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just because of markdown formatter in my editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to do this? Is there some explanation from your editor?

I'm not sure if another editor would change this back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@windsonsea windsonsea windsonsea left review comments

@Arhell Arhell Awaiting requested review from Arhell

@Poor12 Poor12 Awaiting requested review from Poor12

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devleejb @karmada-bot @RainbowMango @windsonsea