Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: translate zh/tutorials/autoscaling-with-custom-metrics #603

Merged
merged 1 commit into from
May 20, 2024
Merged

doc: translate zh/tutorials/autoscaling-with-custom-metrics #603

merged 1 commit into from
May 20, 2024

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented May 17, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
translate zh/tutorials/autoscaling-with-custom-metrics

Which issue(s) this PR fixes:

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 17, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2024
windsonsea
windsonsea reviewed May 17, 2024
View reviewed changes
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md Outdated
```
为了发送 http 请求，这里我们使用 `hey`。
* 下载 `hey` 并复制到 kind 集群容器中。
```sh
$ wget https://hey-release.s3.us-east-2.amazonaws.com/hey_linux_amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在复制粘贴命令后，用户还需要手动删除 $ 符号，多了一步操作。所以很多纯命令的 block，没必要加 $ 吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, agree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个如果要改，其他文档应该也有很多处可以优化。之后可以在另外的 PR 中单独修改这一块。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个如果要改，其他文档应该也有很多处可以优化。之后可以在另外的 PR 中单独修改这一块。

+1

@B1F030
Copy link
Contributor Author

B1F030 commented May 17, 2024

/cc @zhzhuang-zju

@RainbowMango
Copy link
Member

/assign @windsonsea @zhzhuang-zju
to take another look

@B1F030 thanks for doing this, it'd be great if you could help squash commits.

zhzhuang-zju
zhzhuang-zju reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B1F030 Thanks for your work.

others LGTM

i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md Outdated Show resolved Hide resolved
windsonsea
windsonsea reviewed May 20, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
RainbowMango
RainbowMango approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@karmada-bot karmada-bot merged commit 2ac3c63 into karmada-io:main May 20, 2024
7 checks passed
@B1F030 B1F030 mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees

@windsonsea windsonsea

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@B1F030 @RainbowMango @karmada-bot @windsonsea @zhzhuang-zju