Update istio x create-remote-secret examples to istio create-remote-secret
#590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/documentation
|
Welcome @devleejb! It looks like this is your first PR to karmada-io/website 🎉 |
karmada-bot
added
the
size/M
|
Please run the following command to add your signature: |
Signed-off-by: devleejb <[email protected]>
|
@windsonsea I applied it. Thanks. |
|
Thanks for doing this. Leave LGTM to @windsonsea |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The
create-remote-secretcommand in Istio is no longer experimental, therefore, all examples usingistio x create-remote-secrethave been updated toistio create-remote-secret. This update ensures consistency and reflects the current status of the command.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
It was observed that using
istio x create-remote-secretmay result in errors due to missing arguments, such as--name. By transitioning all examples toistio create-remote-secret, these potential errors are avoided, and users can seamlessly utilize the command without issues.For more detailed information, please refer to the Istio documentation here.