Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detailed instruction for global search #577

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add more detailed instruction for global search #577

merged 1 commit into from
Mar 25, 2024

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add more detailed instruction for global search.

Which issue(s) this PR fixes:
Fixes karmada-io/karmada#4678

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 8, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @wengyao04 @windsonsea @RainbowMango

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: wengyao04.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wengyao04 @windsonsea @RainbowMango

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Mar 8, 2024
Closed
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-more-detailed-instructions-for-global-search branch from 75970a9 to 3191612 Compare March 11, 2024 01:40
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-more-detailed-instructions-for-global-search branch from 3191612 to 4eb0d2e Compare March 11, 2024 01:52
@windsonsea
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2024
RainbowMango
RainbowMango approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@karmada-bot karmada-bot merged commit dc1f340 into karmada-io:main Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Poor12 Poor12 Awaiting requested review from Poor12

@samzong samzong Awaiting requested review from samzong

@Tingtal Tingtal Awaiting requested review from Tingtal

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does Karmada search support pod log from managed clusters ?
4 participants
@XiShanYongYe-Chang @karmada-bot @windsonsea @RainbowMango