Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add case study for unionbigdata in English #566

Merged

Conversation

pandaoknight
Copy link
Contributor

What type of PR is this?

/kind documentation

What does this PR do / why do we need it:

This PR adds an English case study titled "UnionBigData's Utilization of Karmada in the Construction of I3Plat at BOE."

Which issue(s) does this PR fix:
Fixes #none

Special notes for your reviewer:

The first two pictures of the architecture have been redrawn in both English and Chinese. The last five pictures remain unchanged. May readers understand them by referring to the context.

I have generated and reviewed the English translation myself. I believe it is understandable, and the terms are correct.

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 18, 2024
@karmada-bot
Copy link
Collaborator

Welcome @pandaoknight! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2024
@pandaoknight
Copy link
Contributor Author

I noticed the DCO problems, I'll fix it right now with new signed-off-by line.

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few concerns about headings

---

## 行业背景
## 1. Industry Background
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1. Industry Background
## Industry Background

Not very necessary to maintain both ## and 1., which have the same meaning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the numbers.


```
/apis/cluster.karmada.io/v1alpha1/clusters/%s/proxy/api/v1/namespaces/%s/services/%s/proxy/%s
```

#### 1、集群监控
#### 2.2.1. Cluster Monitoring
Copy link
Member

@windsonsea windsonsea Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### 2.2.1. Cluster Monitoring
#### Cluster Monitoring

ditto. It need to change more than your expected if you add or remove sections in future

Copy link
Contributor Author

@pandaoknight pandaoknight Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I've removed all the numbers. Should I add a new commit or squash them into one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all right. It has only one commit now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all right. It has only one commit now.

Thanks for reviewing.

@pandaoknight pandaoknight force-pushed the add-unionbigdata-english-case-study branch from 6b4711f to d490ce4 Compare February 18, 2024 08:38
@pandaoknight pandaoknight force-pushed the add-unionbigdata-english-case-study branch from d490ce4 to b09295d Compare February 18, 2024 09:04
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @pandaoknight @windsonsea ~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@karmada-bot karmada-bot merged commit 07bc3ec into karmada-io:main Feb 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants