Merge pull request #5726 from RainbowMango/automated-cherry-pick-of-#…

…5685-upstream-release-1.9 Automated cherry pick of #5685: add ResourceSummary deep copy in general-estimator
karmada-io · Oct 23, 2024 · 7c6c860 · 7c6c860
2 parents 6b00f7b + 10f3152
commit 7c6c860
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/estimator/client/general.go b/pkg/estimator/client/general.go
@@ -54,7 +54,8 @@ func (ge *GeneralEstimator) MaxAvailableReplicas(_ context.Context, clusters []*
 }
 
 func (ge *GeneralEstimator) maxAvailableReplicas(cluster *clusterv1alpha1.Cluster, replicaRequirements *workv1alpha2.ReplicaRequirements) int32 {
-	resourceSummary := cluster.Status.ResourceSummary
+	//Note: resourceSummary must be deep-copied before using in the function to avoid modifying the original data structure.
+	resourceSummary := cluster.Status.ResourceSummary.DeepCopy()
 	if resourceSummary == nil {
 		return 0
 	}