Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shortcuts #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

InfiniteCoder06
Copy link
Contributor

Links with #35

@InfiniteCoder06 InfiniteCoder06 changed the title Add Shortcuts [WIP] Add Shortcuts Oct 18, 2024
@InfiniteCoder06 InfiniteCoder06 changed the title [WIP] Add Shortcuts Add Shortcuts Oct 18, 2024
Copy link
Owner

@karasevm karasevm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have a general question on the way the shortcuts are supposed to work. From reading the code I understand that neither shortcuts modify the provider, the toggle one switches from any other mode to off and then to the first enabled in the app, the switch just toggles through the enabled modes but also to off if a provider is set. Am I correct? Could you please provide an example for each one, as I'm not sure why we need both?

@InfiniteCoder06
Copy link
Contributor Author

InfiniteCoder06 commented Oct 30, 2024

the toggle one switches from any other mode to off

Exactly

switch just toggles through the enabled modes but also to off if a provider is set

Yeah, Overlooked it, The Actual Usecase is just to switch Private Providers only and not Off or Auto

Since if It is used by Automation apps it will be difficult if we merge them to implement in that hence i split them

@karasevm
Copy link
Owner

karasevm commented Nov 5, 2024

If by "switch Private Providers only" you mean cycle through the added providers, it still doesn't do that as it never actually does anything with the next provider. In practice I still get Off (if enabled) -> Auto (if enabled) -> existing provider/dns.google.

@InfiniteCoder06
Copy link
Contributor Author

I am lil busy will be working later....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants