-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shortcuts #37
base: main
Are you sure you want to change the base?
Add Shortcuts #37
Conversation
1f4c029
to
b12d53b
Compare
b12d53b
to
d34aa30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have a general question on the way the shortcuts are supposed to work. From reading the code I understand that neither shortcuts modify the provider, the toggle one switches from any other mode to off and then to the first enabled in the app, the switch just toggles through the enabled modes but also to off if a provider is set. Am I correct? Could you please provide an example for each one, as I'm not sure why we need both?
app/src/main/java/ru/karasevm/privatednstoggle/service/ShortcutService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ru/karasevm/privatednstoggle/service/ShortcutService.kt
Show resolved
Hide resolved
1bfc145
to
6a42daf
Compare
Exactly
Yeah, Overlooked it, The Actual Usecase is just to switch Private Providers only and not Off or Auto Since if It is used by Automation apps it will be difficult if we merge them to implement in that hence i split them |
If by "switch Private Providers only" you mean cycle through the added providers, it still doesn't do that as it never actually does anything with the next provider. In practice I still get |
I am lil busy will be working later.... |
Links with #35