VLC-refactor (CSS) Part 4 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikiDi De tests zien er alvast goed uit (http://kal-kastaar.s.redpencil.io:8080/job/kaleidos/job/FeatureBranches/view/change-requests/job/PR-882/) en ik heb zonet ook nog even een merge Neem jij dit op (met het verlof van Sven)? |
MikiDi
reviewed
May 17, 2021
| <div class="vlc-color-badge-holder__label">{{@decisionResultCode.label}}</div> | ||
| <div class="auk-u-flex auk-u-flex--align-baseline"> | ||
| <div class="auk-u-flex__item auk-u-flex__item--shrink"> | ||
| <WebComponents::AuColorBadge @skin="{{this.skin}}" /> |
There was a problem hiding this comment.
Gezien this.skin hier sowieso als een string is, zijn de extra quotes hier niet nodig. Dit mag meteen @skin={{this.skin}} worden. Ik pas het aan.
There was a problem hiding this comment.
Goeie opmerking, bedankt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referentie issue: #732 'Algemene todo: Refactor doel 2 - vlc naar auk'
Om de PR's iets makkelijker/lichter te maken zal ik componenten groeperen in een aantal delen.
Volgende componenten zijn gerefactored (binnen deze PR):
om VLC-componenten te refactoren en niet direct een verandering in functionaliteit/look-and-feel te veroorzaken heb ik nog enkele tijdelijke styling rules toegevoegd. Voor au-kaleidos-css kunnen die gevonden worden onder
au-kaleidos-css/auk-additions.