VLC-refactor (CSS) Part 3 #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce: kaleidos-prototype-v3)
…us-connected' into DES/enhancement/#732-vlc-refactor # Conflicts: # app/components/publications/publication-sidebar.hbs # app/pods/agenda/documents/template.hbs # app/styles/au-kaleidos-css/_auk-scroll-wrapper.scss # app/styles/au-kaleidos-css/_auk-sidebar.scss # app/styles/au-kaleidos-css/_auk-tabs.scss # app/styles/au-kaleidos-css/_s-colors.scss
# Conflicts: # cypress/integration/unit/formally-ok.spec.js
… into DES/enhancement/#732-vlc-refactor
|
Deze even als draft PR opgezet om de testen hiervoor te laten lopen. Als deze ok zijn publish ik dan ook de nieuwe versie van Daarna dus pas mergen. |
|
Na de test die slagen gisteren en de |
ValenberghsSven
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referentie issue: #732 'Algemene todo: Refactor doel 2 - vlc naar auk'
Om de PR's iets makkelijker/lichter te maken zal ik componenten groeperen in een aantal delen.
Volgende componenten zijn gerefactored (binnen deze PR):
om VLC-componenten te refactoren en niet direct een verandering in functionaliteit/look-and-feel te veroorzaken heb ik nog enkele tijdelijke styling rules toegevoegd. Voor au-kaleidos-css kunnen die gevonden worden onder
au-kaleidos-css/auk-additions.