VLC-refactor (CSS) Part 1 #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brenner-company De testen kleuren allemaal groen :-) Als je de CSS sources hier terug uit haalt is deze klaar voor merge denk ik .. |
|
@MikiDi Aanpassingen zijn doorgevoerd (ook binnen de au-kaleidos-css package). Die mag dus gewoon gemerged worden? |
MikiDi
reviewed
Apr 19, 2021
app/components/access-level-pill.js
Outdated
| break; | ||
| } | ||
| if (modifier) { | ||
| classes.push(`${baseClass}--${modifier}`); | ||
| } | ||
| } | ||
| return classes.join(' '); | ||
| return `${classes.join(' ')} auk-u-cursor-pointer`; |
There was a problem hiding this comment.
Kan je auk-u-cursor-pointer inline bijsteken in classes (l 35)?
|
Omdat deze PR één deel van verscheidene is binnen de VLC-refactor zal ik dezelfde branch verder gebruiken. Niet verwijderen dus 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referentie issue: #732 'Algemene todo: Refactor doel 2 - vlc naar auk'
Om de PR's iets makkelijker/lichter te maken zal ik componenten groeperen in een aantal delen.
Volgende componenten zijn gerefactored:
om VLC-componenten te refactoren en niet direct een verandering in functionaliteit/look-and-feel te veroorzaken heb ik nog enkele tijdelijke styling rules toegevoegd. Voor au-kaleidos-css kunnen die gevonden worden onder
au-kaleidos-css/auk-additions.